Making vows makroo

Assalamualaikum,
I recently found out the making vows such as if I get a job I will pray 10 rakat nafl and fast for 10 days is Makroo. Growing up this was very common and looked at as a good thing. I plan on not doing this in the future and I feel guilty that I did this in the past. A few years ago In Ramadan I made a Dua that if Allah blessed me with a good spouse I will fast for a month and do Quran khatums. I am not married yet but I want to know if I can do this prior to getting married and ask Allah for a good spouse instead of doing it after marriage since it is discouraged to put conditions on your Dua. Or is this fard for me to do now since I had already made the vow not knowing it was disliked to do so rather I had thought it was a good thing that was done to thank Allah when your Dua is fulfilled